Skip to content

pass deken upload bool instead of action-side checks#8

Merged
jamesb93 merged 1 commit intoflucoma:mainfrom
ben-wes:add/deken
Feb 5, 2026
Merged

pass deken upload bool instead of action-side checks#8
jamesb93 merged 1 commit intoflucoma:mainfrom
ben-wes:add/deken

Conversation

@ben-wes
Copy link
Contributor

@ben-wes ben-wes commented Jan 3, 2026

this will make it easier to also handle nightly uploads. it also seems like the better design to not include this logic on the action side.

note that the actions for flucoma-pd still require a v6 tag here. if that's not desired, we can also adapt the action calls and not pin them to a specific version.

@tremblap
Copy link
Member

tremblap commented Jan 4, 2026

this (and the tick box on flucoma/flucoma-pd#118 ) are great. If @jamesb93 as the actions-boss approves, then we can merge and test on the nightlies (to test the puredata.info account credentials I've entered)

@tremblap tremblap requested a review from jamesb93 February 4, 2026 12:00
@jamesb93 jamesb93 merged commit 5f3069d into flucoma:main Feb 5, 2026
@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

thanks for merging, @jamesb93 !

i just realized that you already tagged v6 in this context in december (didn't see that back then):
https://github.com/flucoma/actions/releases/tag/v6

... that will obviously cause the latest action changes to be ignored when running the actions from flucoma-pd. hmm ... so i assume we'd either need to remove the tag and add it to the recent changes or bump the version once more.

@jamesb93
Copy link
Member

jamesb93 commented Feb 5, 2026

thanks for merging, @jamesb93 !

i just realized that you already tagged v6 in this context in december (didn't see that back then): https://github.com/flucoma/actions/releases/tag/v6

... that will obviously cause the latest action changes to be ignored when running the actions from flucoma-pd. hmm ... so i assume we'd either need to remove the tag and add it to the recent changes or bump the version once more.

I'm not sure I follow (my own work alas...)

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

not sure I follow

i didn't see that v6 was already tagged here. since the workflows are calling the actions @v6, they're now still using the december version which doesn't include the recent changes. this is obviously exactly the purpose of this version pinning in that case - i just didn't realize that this tag was already present. my fault, sorry!

as i said: you should be able to remove the v6 tag here and add it to the latest changes. or we'll need to tag a v7 now and call the actions with @v7 in:

(or we use a branch reference instead of a tag, replacing @v6 with @main - in that case, the workflows would always use the latest actions. i'm just not sure if that's acceptable since you're already using the tag reference, which feels cleaner)

@tremblap
Copy link
Member

tremblap commented Feb 5, 2026

@ben-wes is that why the upload didn't work?

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

is that why the upload didn't work?

i assume so. the expected action interface changed - so there is a mismatch now.

let me know which of the above options you want to use (EDIT: if we change the action calls, i can quickly provide a PR). and sorry again for missing this already present v6 tag!

@tremblap
Copy link
Member

tremblap commented Feb 5, 2026

you seem to know better than me how to fix it, so please make a pr with your hypothesis and I'll merge right away and start a nightly process (IIRC nightlies will also upload so I shoukd see them in the flucoma account at puredata.info in 'myfolder' riught?

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

make a pr with your hypothesis

see flucoma/flucoma-pd#120

I should see them in the flucoma account at puredata.info in 'myfolder' right?

exactly!

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

@tremblap
Copy link
Member

tremblap commented Feb 5, 2026

hurray! thanks for your patience and effort.

@jamesb93
Copy link
Member

jamesb93 commented Feb 5, 2026

great work!

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 5, 2026

thanks for your work on this and for trusting my contributions here, @tremblap and @jamesb93. i'm glad that i can now simply point people to deken when it comes to installing flucoma. :)

@ben-wes ben-wes deleted the add/deken branch February 5, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants