pass deken upload bool instead of action-side checks#8
Conversation
|
this (and the tick box on flucoma/flucoma-pd#118 ) are great. If @jamesb93 as the actions-boss approves, then we can merge and test on the nightlies (to test the puredata.info account credentials I've entered) |
|
thanks for merging, @jamesb93 ! i just realized that you already tagged v6 in this context in december (didn't see that back then): ... that will obviously cause the latest action changes to be ignored when running the actions from |
I'm not sure I follow (my own work alas...) |
i didn't see that as i said: you should be able to remove the
(or we use a branch reference instead of a tag, replacing |
|
@ben-wes is that why the upload didn't work? |
i assume so. the expected action interface changed - so there is a mismatch now. let me know which of the above options you want to use (EDIT: if we change the action calls, i can quickly provide a PR). and sorry again for missing this already present |
|
you seem to know better than me how to fix it, so please make a pr with your hypothesis and I'll merge right away and start a nightly process (IIRC nightlies will also upload so I shoukd see them in the flucoma account at puredata.info in 'myfolder' riught? |
exactly! |
|
https://deken.puredata.info/search.html?libraries=&objects=flucoma&descriptions= \o/ EDIT: and obviously as well here then ...
EDIT2: and here ... https://puredata.info/Members/flucoma/software/FluidCorpusManipulation/ |
|
hurray! thanks for your patience and effort. |
|
great work! |

this will make it easier to also handle nightly uploads. it also seems like the better design to not include this logic on the action side.
note that the actions for
flucoma-pdstill require av6tag here. if that's not desired, we can also adapt the action calls and not pin them to a specific version.